chore: bump NosCore.Packets to 18.0.0#12
Merged
erwan-joly merged 1 commit intomasterfrom Apr 24, 2026
Merged
Conversation
Picks up breaking schema fixes: fish reduced to Type + catch-all body, qstlist flat quest layout, NsTeST unknown fields, NsTeStSubPacket.Port widened to int? for the -1 sentinel. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe pull request updates the central NuGet package manifest to bump the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NosCore.Packetsto 18.0.0, which brings the schema fixes forfish(reduced toType+ catch-all body),qstlist(flat 16-field quest layout),NsTeST(six new unknown fields betweenUnknownandServerCharacters), andNsTeStSubPacket.Port(widened toint?so the-1sentinel round-trips).Test plan
dotnet build -c Releasecleandotnet publishto./publish/succeeds; validator works against captured traffic🤖 Generated with Claude Code
Summary by CodeRabbit